[PATCH] D35612: Given preference to @@ symbols

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 00:04:06 PDT 2017


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: ELF/SymbolTable.cpp:339
+  // we can delete this hack.
+  if (Name.find("@@") != StringRef::npos &&
+      S->body()->getName().find("@@") == StringRef::npos)
----------------
May be move this code to separate static function to incapsulate this hack ?



https://reviews.llvm.org/D35612





More information about the llvm-commits mailing list