[PATCH] D35609: [LICM] Make sinkRegion and hoistRegion non-recursive

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 22:59:53 PDT 2017


majnemer added a comment.

In https://reviews.llvm.org/D35609#814134, @davide wrote:

> The idea is sound, I'll think a little bit more about the visitation order (tomorrow morning) but it seems you got it right.
>  Just a minor nit, I see this patch has some unrelated formatting, mind to revert that? (and/or commit separately)


AFAICT, iterating over the worklist caused the nesting to increase which caused the formatting to change.


https://reviews.llvm.org/D35609





More information about the llvm-commits mailing list