[PATCH] D35593: ThinLTOBitcodeWriter: Do not rewrite intrinsic functions when splitting modules.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc created this revision.
Herald added subscribers: hiraditya, eraman, inglorion, mehdi_amini.

Changing the type of an intrinsic may invalidate the IR.


https://reviews.llvm.org/D35593

Files:
  llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc.ll


Index: llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc.ll
===================================================================
--- llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc.ll
+++ llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc.ll
@@ -25,9 +25,13 @@
 ; M0: define i64 @ok2
 ; M1: define available_externally i64 @ok2
 define i64 @ok2(i8* %this, i64 %arg) {
+  %1 = tail call { i64, i1 } @llvm.sadd.with.overflow.i64(i64 %arg, i64 %arg)
   ret i64 %arg
 }
 
+; M1: declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
+declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
+
 ; M0: define void @wrongtype1
 ; M1: declare void @wrongtype1()
 define void @wrongtype1(i8*) {
Index: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
===================================================================
--- llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
+++ llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
@@ -141,7 +141,8 @@
       continue;
     }
 
-    if (!F.isDeclaration() || F.getFunctionType() == EmptyFT)
+    if (!F.isDeclaration() || F.getFunctionType() == EmptyFT ||
+        F.getName().startswith("llvm."))
       continue;
 
     Function *NewF =


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35593.107213.patch
Type: text/x-patch
Size: 1192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170719/42d87d74/attachment.bin>