[PATCH] D35592: [WebAssembly] Remove duplicated RTLIB names

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 17:05:04 PDT 2017


dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp:883
 
+static StringRef StringRefOrEmpty(const char* arg) {
+  if (arg) return StringRef(arg);
----------------
Can't construct a StringRef will nullptr, so we have this bit of ugliness.


https://reviews.llvm.org/D35592





More information about the llvm-commits mailing list