[PATCH] D35292: [SLPVectorizer] Add propagateIRFlagsWithOp() function to propagate IRFlags for specific Operation

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 15:25:18 PDT 2017


filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:535
+/// If OpValue is set then we consider only similar operation to OpValue in
+/// the intersection.
 /// Flag set: NSW, NUW, exact, and all of fast-math.
----------------
Maybe "If OpValue is non-null, we only consider operations similar to OpValue when intersecting"?


================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1396
+    else if (Opcode == Instr->getOpcode())
+      VecOp->andIRFlags(V);
   }
----------------
Merge these:
```if (OpValue == nullptr || Opcode == Instr->getOpcode())
  VecOp->andIRFlags(V);```


https://reviews.llvm.org/D35292





More information about the llvm-commits mailing list