[PATCH] D35346: [CMake] Enable buildings builtins for Darwin as part of runtimes

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 13:48:51 PDT 2017


phosek added a comment.

In https://reviews.llvm.org/D35346#813474, @beanz wrote:

> So... Looking at the CMake in compiler-rt, `COMPILER_RT_DEFAULT_TARGET_ONLY` is only interpreted in a `NOT APPLE` block, so this would really not behave the way you intend. I think it is better to not support this on Darwin for the time being and provide a hard error rather than behaving incorrectly.
>
> I suspect if you passed in multiple Darwin triples in `LLVM_BUILTIN_TARGETS` you'd get multiple copies of all the Darwin builtin libraries being built.


Would it be OK to avoid throwing error in case the `$target` is `default` (even on Darwin)? That's all I need at the moment.


Repository:
  rL LLVM

https://reviews.llvm.org/D35346





More information about the llvm-commits mailing list