[PATCH] D35544: [COFF, ARM64] Force ADRP relocations

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:585
+                             const MCValue &Target) override {
+    // The same reason as in ELFAArch64AsmBackend above
+    if ((uint32_t)Fixup.getKind() == AArch64::fixup_aarch64_pcrel_adrp_imm21)
----------------
Period at the end of comment.


================
Comment at: test/MC/AArch64/adrp-relocation-coff.s:1
+// RUN: llvm-mc -triple=aarch64-windows -filetype=obj -o - %s| llvm-readobj -r - | FileCheck %s
+        .text
----------------
There's already a test case for coff relocations: test/MC/AArch64/coff-relocations.s. Would you mind adding to the same file instead of creating a new one just for adrp relocs?


https://reviews.llvm.org/D35544