[PATCH] D35528: [Dominators] Teach LoopUnswitch to use the incremental API

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 09:56:17 PDT 2017


kuhar added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:939
+  assert(isa<BranchInst>(loopPreheader->getTerminator()));
+  auto *OldBranch = cast<BranchInst>(loopPreheader->getTerminator());
   EmitPreheaderBranchOnCondition(Cond, Val, NewExit, NewPH,
----------------
davide wrote:
> instead of using isa<> + cast<> can you use `dyn_cast<>` maybe ?
Wouldn't that be slower in release builds without assertions?


https://reviews.llvm.org/D35528





More information about the llvm-commits mailing list