[PATCH] D35563: [DAG] Optimize away degenerate INSERT_VECTOR_ELT nodes.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 09:29:16 PDT 2017


RKSimon added a comment.

I've updated the shifts tests to include the constant broadcast comments - please can you rebase?



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13500
+      InVec == InVal->getOperand(0) && EltNo == InVal->getOperand(1))
+    return InVec;
+
----------------
Hmm, is this worth putting before the if (!isa<ConstantSDNode>(EltNo)) early out to support non-constant extract+insert?


https://reviews.llvm.org/D35563





More information about the llvm-commits mailing list