[PATCH] D35522: Move Runtime libcall definitions to a .def file

Daniel Neilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 09:15:05 PDT 2017


dneilson added a comment.

This looks good to me -- very clean. I'm quite new to LLVM, so I don't feel comfortable giving this a go-ahead; I'll leave that to someone more experienced.

How would this be used in the WebAssembly backend? Would the idea be to expand the def file to provide the required WebAssembly values in each HANDLE_LIBCALL macro? Or change the static arrays to helper functions with a giant switch-case? Or... ?


https://reviews.llvm.org/D35522





More information about the llvm-commits mailing list