[PATCH] D35477: [ELF] - Print options aliases in --help

[George Rimar via llvm-commits]

>George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
>> -def alias_defsym: S<"defsym">, Alias<defsym>;
>> +def alias_defsym: S<"defsym">, Alias<defsym>, Flags<[HelpHidden]>;
>
>Is there a rule for which one is hidden? In the other cases the ones
>ending in = are hidden.

Yes, I tried to follow next rule:
1) I applied HelpHidden flag only for Aliases group. That is easier to handle when you can expect Hidden flag only
in one place.
2) And only for those aliases that are 'similar' with target option they refer to.

By 'similar' I mean ZZZ and ZZZ= forms. It is too verbose IMO when we have something like:
--entry <entry>, --entry=<value>, -e <value>.

IMO it better to stay on:
--entry <entry> , -e <value>.

Like this patch do.

Problem is that we are not consistent currently. Sometimes we have option "XXX" and alias "XXX=",
but sometimes have option "YYY=" and alias "YYY". That makes output to be a bit messy, probably.
I think we should be consistent and fix that. That can be separate change though, I'll post a patch.

>> -def alias_entry_entry: J<"entry=">, Alias<entry>;
>> -def alias_error_limit: J<"error-limit=">, Alias<error_limit>;
>> -def alias_exclude_libs: J<"exclude-libs=">, Alias<exclude_libs>;
>> +def alias_entry_entry: J<"entry=">, Alias<entry>, Flags<[HelpHidden]>;
>> +def alias_error_limit: J<"error-limit=">, Alias<error_limit>, Flags<[HelpHidden]>;
>
>This just deletes alias_exclude_libs.

That was a mistake :( I'll restore it back.

Cheers,
Rafael