[PATCH] D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Ok, I'm now completely happy with the code as is (barring one more nit in a comment). Just the testing left.

I don't know how you're getting on with segments and yaml2obj, but there is precedent for checking in pre-built binaries in the Lit tests, if it's not possible to create the inputs from raw assembly or similar. That might be a way forward if yaml2obj support is going to take some time.



================
Comment at: tools/llvm-objcopy/Object.cpp:226
+    // Alignment should have already been handled by the above if statement if
+    // this section belonged in a segment. Technically this shouldn't do
+    // anything bad if the alignments of the sections are all correct and the
----------------
Nit: I'd use "if this section is in a segment" instead of belonged in, because something might belong in something else, but for whatever reason wasn't put in there.


Repository:
  rL LLVM

https://reviews.llvm.org/D33964