[PATCH] D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses

Pedro Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 01:06:15 PDT 2017


PFerreira added a comment.

A-ha, I see your point. Apologies for the confusion, but as I mentioned before, it was my hack on GVN.

I wouldn't be able to say if this improves performance or not; the original bug isn't mine. I found it on bugzilla and thought it might be something interesting to hack on.
If you'd prefer to fix the bug by disabling parts of the transformation, should I discard this review?


https://reviews.llvm.org/D35475





More information about the llvm-commits mailing list