[PATCH] D35518: [COFF, ARM64, CodeView] Add support to emit CodeView debug info for ARM64 COFF

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 20:08:01 PDT 2017


majnemer added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:307
                                      CodeViewLineTablesGroupDescription));
-    }
-    if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
+    } else if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
       DD = new DwarfDebug(this, &M);
----------------
Hrm, why isn't this just `if (MMI->getModule()->getDwarfVersion())` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D35518





More information about the llvm-commits mailing list