[LNT] r308255 - NTEmailReport: Remove unused parameter, hide internal function; NFC

[Matthias Braun via llvm-commits]

Author: matze
Date: Mon Jul 17 19:06:37 2017
New Revision: 308255

URL: http://llvm.org/viewvc/llvm-project?rev=308255&view=rev
Log:
NTEmailReport: Remove unused parameter, hide internal function; NFC

Modified:
    lnt/trunk/lnt/util/ImportData.py
    lnt/trunk/lnt/util/NTEmailReport.py

Modified: lnt/trunk/lnt/util/ImportData.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/util/ImportData.py?rev=308255&r1=308254&r2=308255&view=diff
==============================================================================
--- lnt/trunk/lnt/util/ImportData.py (original)
+++ lnt/trunk/lnt/util/ImportData.py Mon Jul 17 19:06:37 2017
@@ -109,8 +109,8 @@ def import_and_report(config, db_name, d
     if not disable_report:
         #  This has the side effect of building the run report for
         #  this result.
-        NTEmailReport.emailReport(result, db, run, report_url,
-                                  email_config, toAddress, success, commit)
+        NTEmailReport.emailReport(result, db, run, report_url, email_config,
+                                  toAddress, success)
 
     result['added_machines'] = ts.getNumMachines() - numMachines
     result['added_runs'] = ts.getNumRuns() - numRuns

Modified: lnt/trunk/lnt/util/NTEmailReport.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/util/NTEmailReport.py?rev=308255&r1=308254&r2=308255&view=diff
==============================================================================
--- lnt/trunk/lnt/util/NTEmailReport.py (original)
+++ lnt/trunk/lnt/util/NTEmailReport.py Mon Jul 17 19:06:37 2017
@@ -7,13 +7,12 @@ import StringIO
 import lnt.server.db.v4db
 import lnt.server.reporting.runs
 
-def emailReport(result, db, run, baseurl, email_config, to, was_added=True,
-                will_commit=True):
+def emailReport(result, db, run, baseurl, email_config, to, was_added=True):
     import email.mime.multipart
     import email.mime.text
 
-    subject, report, html_report = getReport(result, db, run, baseurl,
-                                             was_added, will_commit)
+    subject, report, html_report = _getReport(result, db, run, baseurl,
+                                              was_added)
 
     # Ignore if no to address was given, we do things this way because of the
     # awkward way we collect result information as part of generating the email
@@ -43,8 +42,7 @@ def emailReport(result, db, run, baseurl
     s.sendmail(email_config.from_address, [to], msg.as_string())
     s.quit()
 
-def getReport(result, db, run, baseurl, was_added, will_commit,
-              compare_to=None):
+def _getReport(result, db, run, baseurl, was_added, compare_to=None):
     assert isinstance(db, lnt.server.db.v4db.V4DB)
 
     data = lnt.server.reporting.runs.generate_run_data(run, baseurl=baseurl,