[PATCH] D35518: [COFF, ARM64, CodeView] Add support to emit CodeView debug info for ARM64 COFF

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:307-308
                                      CodeViewLineTablesGroupDescription));
     }
-    if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
+    else if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
       DD = new DwarfDebug(this, &M);
----------------
ruiu wrote:
> Please fix style.
The old way of doing this supported emitting both dwarf and CV, which we briefly considered to be interesting. There isn't any real use case for it, but I think I'd prefer it if these things were independent. We shouldn't have a dwarf version flag if the frontend wants us to emit codeview.


Repository:
  rL LLVM

https://reviews.llvm.org/D35518