[PATCH] D35495: [codeview] Fix YAML for LF_TYPESERVER2 by hoisting PDB_UniqueId

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 16:40:59 PDT 2017


rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:510
 
-  pdb::PDB_UniqueId uuid{};
+  WindowsGuid uuid{};
   if (DI)
----------------
ruiu wrote:
> Is WindowsGuid an appropriate name for this data strucutre? This is just a GUID and not really an Windows-variant.
This was an attempt to distinguish it from `llvm::GlobalValue::GUID`, which is a 64-bit integer, but sure, we can call it GUID.


https://reviews.llvm.org/D35495





More information about the llvm-commits mailing list