[PATCH] D35444: [DWARF] Modification of code for the verification of .debug_info section.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with outstanding changes applied. Thanks!



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:142
+      // UnitType = 0 means that we are
+      // verifying a compile unit in dwarf4 version.
+      case 0: {
----------------
-> for consistency: `in DWARF v4.`


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:172
+                                             DWARFAttribute &AttrValue,
+                                             uint32_t &NumUnitErrors) {
   const auto Attr = AttrValue.Attr;
----------------
Perhaps return the number of errors:

`unsigned DWARFVerifier::verifyDebugInfoAttribute(const DWARFDie &Die,                         DWARFAttribute &AttrValue);`


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:285
 
-void DWARFVerifier::verifyDebugInfoReferences() {
+void DWARFVerifier::verifyDebugInfoReferences(uint32_t &NumDebugInfoErrors) {
   // Take all references and make sure they point to an actual DIE by
----------------
same here


https://reviews.llvm.org/D35444