[PATCH] D35515: [PDB] Finish and simplify TPI hashing

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
Herald added a subscriber: hiraditya.

This removes the CVTypeVisitor updater and verifier classes. They were
made dead by the minimal type dumping refactoring. Replace them with a
single function that takes a type record and produces a hash. Call this
from the minimal type dumper and compare the hash.

I also noticed that the microsoft-pdb reference repository uses a basic
CRC32 for records that aren't special. We already have an implementation
of that CRC ready to use, because it's used in COFF for ICF.

I'll make LLD call this hashing utility in a follow-up change. We might
also consider using this same hash in type stream merging, so that we
don't have to hash our records twice.


https://reviews.llvm.org/D35515

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/TpiHashing.h
  llvm/lib/DebugInfo/PDB/Native/TpiHashing.cpp
  llvm/test/DebugInfo/PDB/pdbdump-headers.test
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-pdbutil/MinimalTypeDumper.cpp
  llvm/tools/llvm-pdbutil/MinimalTypeDumper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35515.106973.patch
Type: text/x-patch
Size: 40297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170717/05772eae/attachment.bin>