[PATCH] D35412: [ELF] - Fix incorrect object file use with --reproduce option.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 16:11:47 PDT 2017


ruiu added a comment.

I might be OK with the feature, but this particular patch needs fixing from my point of view.

- `--reproduce-use` doesn't sound quite right as an option name. I'd vote for `--chroot <dirname>`.
- Handling this case in ScriptParser::addFile is not right. You should do this in Driver::addFile.
- If you do this, you probably should remove `rewritePath` as it is no longer needed.


https://reviews.llvm.org/D35412





More information about the llvm-commits mailing list