[PATCH] D35498: [LoopVectorizer] Use two step casting for float to pointer type.

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 15:33:37 PDT 2017


mkuper added a comment.

> Should I update the Builder's CreateBitOrPointerCast function to handle float to pointer casts using float -> int and int -> pointer casts? I can do that or I can create a local pass specific casting function to handle  float -> ptr + other CreateBitOrPointerCast routines used here.

Why can't you do the bitcast directly inside CreateBitOrPointerCast()? You'll also want to upadte isBitOrNoopPointerCastable(),
Anyway, you probably want a different set of reviewers for that patch - I'm really not the authority on that, and at least Renato seems to have a completely different opinion.

> I am trying to create a reduced test case but no success so far.

The standard way to do this is to dump the IR just before the vectorizer, and then use bugpoint to reduce.
Have you tried that?


https://reviews.llvm.org/D35498





More information about the llvm-commits mailing list