[PATCH] D35333: Create empty shell of llvm-mt.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM



================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:71
+
+int main(int argc_, const char *argv_[]) {
+  sys::PrintStackTraceOnErrorSignal(argv_[0]);
----------------
ecbeckmann wrote:
> ruiu wrote:
> > ruiu wrote:
> > > ecbeckmann wrote:
> > > > ruiu wrote:
> > > > > ruiu wrote:
> > > > > > Please follow the LLVM naming convention.
> > > > > `argc` and `argv` still don't follow the LLVM naming convention.
> > > > on most recent revision this should be fine
> > > Is it? `argc` and `argv` should be `Argc` and `Argv`.
> > Please fix.
> Hmmm I'm not sure if Argc and Argv are the convention in this case.  In all the other "mains" in llvm/tools there is variation between using argc, argc_ and *argv[], **argv, *argv_[].  The most common combination is argc and **argv.
If that is a convention, that is fine, but I hope you mentioned that instead of just marking this as done.


https://reviews.llvm.org/D35333