[PATCH] D35496: [codeview] Don't use the type visitor to merge types

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 10:51:09 PDT 2017


ruiu added a comment.

I agree that this is a nice simplification.



================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:282
+  discoverTypeIndices(Type.RecordData, Refs);
+  bool Success = remapIndices(R, Refs);
+  if (isIdRecord(Type.kind())) {
----------------
What is the meaning of this boolean varaible? Looks like you are not using its value.


https://reviews.llvm.org/D35496





More information about the llvm-commits mailing list