[PATCH] D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio
michael zuckerman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 17 05:07:50 PDT 2017
m_zuckerman added inline comments.
================
Comment at: lib/Target/X86/X86.td:419-420
FeatureSlowIncDec,
FeatureSlowBTMem,
- FeatureSlowPMULLD,
- FeatureLAHFSAHF
+ FeatureRDRAND
+]>;
----------------
craig.topper wrote:
> This looks to be adding RDRAND to SLM. Whether that's correct or not, that's a functional change which should not be part of this patch.
hi.
First, this feature is part of SLM.
Secondly , why don't you want it as part of the patch ?
================
Comment at: lib/Target/X86/X86.td:428
+ FeatureSlowUAMem16,
+ FeatureSSSE3,
+ FeatureSlowBTMem,
----------------
craig.topper wrote:
> Should SSSE3 be part of AtomValues instead? The rest of these are uarch details, but that one is a real feature and should be with the other features.
Higher features hint for lower features. In this case feature SSSE3 is part of the SSE42 so i didn't want to create a duplication.
https://reviews.llvm.org/D35354
More information about the llvm-commits
mailing list