[PATCH] D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86.td:419-420
   FeatureSlowIncDec,
   FeatureSlowBTMem,
-  FeatureSlowPMULLD,
-  FeatureLAHFSAHF
+  FeatureRDRAND
+]>;
----------------
This looks to be adding RDRAND to SLM. Whether that's correct or not, that's a functional change which should not be part of this patch.


================
Comment at: lib/Target/X86/X86.td:428
+  FeatureSlowUAMem16,
+  FeatureSSSE3,
+  FeatureSlowBTMem,
----------------
Should SSSE3 be part of AtomValues instead? The rest of these are uarch details, but that one is a real feature and should be with the other features.


https://reviews.llvm.org/D35354