[PATCH] D34857: [COFF, ARM64] Add initial relocation types

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: test/MC/AArch64/coff-relocations.ll:1
+; RUN: llc -mtriple=aarch64-windows -filetype=obj -o - %s | \
+; RUN: llvm-objdump -r - | FileCheck %s
----------------
Use a .s test instead. You can probably run this file through llc, and then run llvm-mc on that to generate an object.


================
Comment at: test/MC/AArch64/coff-relocations.ll:78
+!0 = !DIGlobalVariableExpression(var: !1)
+!1 = distinct !DIGlobalVariable(name: "arr", scope: !2, file: !3, line: 1, type: !16, isLocal: false, isDefinition: true)
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !5)
----------------
With a .s test, you won't need all this complex debug info to make SECREL and SECTION relocations, you can just directly use the .secrel and .secidx directives.


Repository:
  rL LLVM

https://reviews.llvm.org/D34857