[PATCH] D35422: Add MemoryMappedSection struct for two-level memory map iteration

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 16:21:30 PDT 2017


fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:60
+
+ private:
+#if SANITIZER_MAC
----------------
alekseyshl wrote:
> Move private under #if
Unfortunately, the linter complains if you don't have a blank line before private. It looks a bit odd to me to have:

```
#if SANITIZER_MAC

private:
  friend class MemoryMappingLayout;
```

What do you think?


https://reviews.llvm.org/D35422





More information about the llvm-commits mailing list