[PATCH] D29892: ar: add llvm-dlltool support

[Martell Malone via Phabricator via llvm-commits]

martell added inline comments.


================
Comment at: lib/Object/COFFImportFile.cpp:559-560
+  // Copied here so we can still use writeStringTable
+  memcpy(Alloc.Allocate<char>(Buffer.size()), Buffer.data(), Buffer.size());
+  return {MemoryBufferRef(StringRef(Buf, Buffer.size()), DLLName)};
+}
----------------
ruiu wrote:
> This must not be correct. You are memcpy'ing to some memory region and returning something different.
In a cleanup I removed `char *Buf` so simplify not even realising I needed that reference.
Should be good now. Sorry for the confusion.


Repository:
  rL LLVM

https://reviews.llvm.org/D29892