[PATCH] D35413: [LLD][ELF] Add DefinedInThunk to SymbolBody to remove need for hash lookup

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 14:07:20 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Symbols.h:95-96
   InputFile *File = nullptr;
-
+  // The Thunk that this symbol is defined in, nullptr if not defined in Thunk
+  Thunk *DefinedInThunk = nullptr;
   uint32_t DynsymIndex = 0;
----------------
Please add blank lines above and below this member variable.

`DefinedInThunk` sounds like a boolean variable, so I'd give a different name, but obviously `Thunk` doesn't work. Do you have any suggestion?


https://reviews.llvm.org/D35413





More information about the llvm-commits mailing list