[PATCH] D34690: [LLD][ELF] Introduce target specific inBranchRange() function

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 13:55:21 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Arch/ARM.cpp:230
+  uint64_t InstrSize;
+  switch (RelocType) {
+  case R_ARM_PC24:
----------------
nit: add blank line


================
Comment at: ELF/Arch/ARM.cpp:265-267
+  uint64_t Distance = (Src > Dst) ? Src - Dst : Dst - Src;
+
+  return Distance <= Range;
----------------
maybe `return abs(Src - Dst) <= Range;`?


https://reviews.llvm.org/D34690





More information about the llvm-commits mailing list