[PATCH] D35416: AMDGPU: Fix crash when folding immediates into multiple uses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 10:05:42 PDT 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM but test can be reduced a little bit



================
Comment at: test/CodeGen/MIR/AMDGPU/fold-multiple.mir:34-47
+frameInfo:
+  isFrameAddressTaken: false
+  isReturnAddressTaken: false
+  hasStackMap:     false
+  hasPatchPoint:   false
+  stackSize:       0
+  offsetAdjustment: 0
----------------
You can delete this


================
Comment at: test/CodeGen/MIR/AMDGPU/fold-multiple.mir:56
+    %5 = IMPLICIT_DEF
+    BUFFER_STORE_DWORD_OFFSET killed %4, killed %5, 0, 0, 0, 0, 0, implicit %exec :: (volatile store 2 into `half addrspace(1)* undef`)
+    S_ENDPGM
----------------
You can remove the MMO, the name of the block and then you can remove the IR section


https://reviews.llvm.org/D35416





More information about the llvm-commits mailing list