[PATCH] D33880: COFF: Introduce LD shim around LINK

[Martell Malone via Phabricator via llvm-commits]

martell marked an inline comment as done.
martell added inline comments.


================
Comment at: lld/lib/Shim/COFFLdShim.cpp:1
+//===- lib/Driver/COFFLdShim.cpp ------------------------------------------===//
+//
----------------
ruiu wrote:
> ruiu wrote:
> > martell wrote:
> > > Location Okay?
> > See the comment above.
> > 
> > Rename this file `MingwDriver.cpp`.
> Please move this file as I wrote above.
reiterating my previous question. It probably got lost in the thread.
> Naming everything Mingw Driver doesn't make a lot of sense because this also supports cygwin. That and the possible future targets such as midipix.
Have you any thoughts or suggestions on a more generic naming scheme rui?

Also a comment from @mstorsjo above. 

> Just my 2 cents; I also prefer naming this something like "ld style frontend to the COFF linker" instead of "mingw driver". but in the end, Rui's opinion is what matters of course.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880