[PATCH] D35396: [lit] Make %T return a per-test temporary directory

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:51:26 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D35396#809086, @george.karpenkov wrote:

> @rnk Actually it would be quite easy to do the `mkdir` iff `%T` is present in the file, if performance is a concern.
>  I would argue that test runs should be isolated by the test runner, and test authors should not be trying to judge whether it's safe to share a directory.
>
> In any case, inconsistent documentation should be updated one way or the other.


That sounds like a pretty good idea. :) FWIW, I am concerned about the performance. You can instrument lit to check out log it takes to make the Output directories.


Repository:
  rL LLVM

https://reviews.llvm.org/D35396





More information about the llvm-commits mailing list