[PATCH] D35396: [lit] Make %T return a per-test temporary directory

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:39:23 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D35396#809062, @george.karpenkov wrote:

> @rnk There are two documentation files. The `lit.rst` says it's unique, `TestingGuide.rst` says it's not.
>  So at least that should be fixed.
>  In any case, I disagree with your comment: what if the user still wants to have `%t` to signify a temporary file? Why an extra `mkdir`?


Somebody has to do the mkdir, and it might as well be the test, since those execute in parallel. Right now lit makes Output directories for every suite, not for every test. Running mkdir for every llvm test seems like it would slow down startup.


Repository:
  rL LLVM

https://reviews.llvm.org/D35396





More information about the llvm-commits mailing list