[PATCH] D35394: [codeview] Remove TypeServerHandler and PDBTypeServerHandler

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:13:48 PDT 2017


rnk created this revision.
Herald added subscribers: hiraditya, mgorny.

Instead of wiring these through the CVTypeVisitor interface, clients
should inspect the CVTypeArray before visiting it and potentially load
up the type server's TPI stream if they need it.

No tests relied on this functionality because LLD was the only client.


https://reviews.llvm.org/D35394

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb-type-server-missing.yaml
  llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
  llvm/include/llvm/DebugInfo/CodeView/TypeServerHandler.h
  llvm/include/llvm/DebugInfo/CodeView/TypeStreamMerger.h
  llvm/include/llvm/DebugInfo/PDB/Native/PDBTypeServerHandler.h
  llvm/lib/DebugInfo/CodeView/CVTypeVisitor.cpp
  llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
  llvm/lib/DebugInfo/PDB/CMakeLists.txt
  llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp
  llvm/lib/DebugInfo/PDB/Native/TpiStream.cpp
  llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/unittests/DebugInfo/CodeView/RandomAccessVisitorTest.cpp
  llvm/unittests/DebugInfo/PDB/CMakeLists.txt
  llvm/unittests/DebugInfo/PDB/TypeServerHandlerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35394.106562.patch
Type: text/x-patch
Size: 34473 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/465a4b62/attachment-0001.bin>


More information about the llvm-commits mailing list