[PATCH] D34876: [asan] Remove check for stack size

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 13:36:14 PDT 2017


kcc added a comment.

In https://reviews.llvm.org/D34876#807658, @Hahnfeld wrote:

> In https://reviews.llvm.org/D34876#806869, @kcc wrote:
>
> > This check is a sanity check, please keep it, but feel free to change the constant to e.g. 0x100000000 (16x increase)
>
>
> Sanity check in what sense? If we can increase it arbitrarily, it's not a check anymore IMHO


It's a sanity check that asan has computed the stack size correctly, and that it doesn't think the stack is e.g. 42 Gb


Repository:
  rL LLVM

https://reviews.llvm.org/D34876





More information about the llvm-commits mailing list