[PATCH] D35315: [Dominators] Make IsPostDominator a template parameter

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 10:37:05 PDT 2017


kuhar added a comment.

In https://reviews.llvm.org/D35315#808241, @dberlin wrote:

> For the cases that are always true, can you just use PostDominatorTree instead?


>From what I understand, PostDominatorTree lives in lib/Analysis and I'm not sure if I can include it everywhere.

How about we add something like:

  template <typename T> using ForwardDomTreeBase = DominatorTreeBase<T, false>;
  template <typename T> using PostDomTreeBase = DominatorTreeBase<T, true>;

at the bottom of `GenericDominatorTree.h` and use it instead of `DominatorTreeBase<T, true/false>`?


https://reviews.llvm.org/D35315





More information about the llvm-commits mailing list