[PATCH] D35341: [Dominators] Implement incremental insertions

[Daniel Berlin via Phabricator via llvm-commits]

dberlin accepted this revision.
dberlin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/Support/GenericDomTree.h:451
 
+  /// Inform the dominator tree about an edge insertion and update the tree.
+  ///
----------------
s/edge insertion/CFG edge insertion/


================
Comment at: include/llvm/Support/GenericDomTree.h:455
+  /// on the actual CFG. There cannot be any other updates that the dominator
+  /// tree doesn't know about.
+  /// Note that for postdominators it automatically takes care of inserting
----------------
Will it really work if you do it before the actual cfg change exists?
(IE without that edge, will you still be able to find the right successors, predecessors?)
If so, great!


https://reviews.llvm.org/D35341