[PATCH] D35122: [LoopInterchange] Add some optimization remarks.

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM with one nit below.  Thanks!



================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:809-877
+    ORE->emit(OptimizationRemarkMissed(DEBUG_TYPE,
+                                       "CurrentLimitations",
+                                       InnerLoop->getStartLoc(),
+                                       InnerLoop->getHeader())
+              << "Only outer loops with induction or reduction PHI nodes can be"
+                 " interchanged currently.");
     return true;
----------------
Please use different remark identifier for each remark ("CurrentLimitation" currently).  This way we can measure the different failing cases without parsing the text of the remark.


https://reviews.llvm.org/D35122