[PATCH] D35228: [TableGen] Add support for instruction clusters

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 06:05:39 PDT 2017


hfinkel added a comment.

In https://reviews.llvm.org/D35228#807205, @evandro wrote:

> As it can be seen from the example, the fusion does not spread definitions over multiple files.  In this proposed approach, fusion is specified in the machine model.  Moreover, it folds fusion into the machine scheduling and decreases its run-time cost.  All the while, yielding the same result as before.


I agree, it does not spread the information out over multiple files. However, the fact that the clusters are just specified by numbers makes the implementation less self-explanatory (i.e. it is really not clear what the numbers mean in the model files). I suggest that you add separate tablegen classes that represent the clusters so that you can refer to the clusters by name in the scheduling definitions.


Repository:
  rL LLVM

https://reviews.llvm.org/D35228





More information about the llvm-commits mailing list