[PATCH] D32840: [XRay] convert FDR arg1 log entries

[Keith via Phabricator via llvm-commits]

kpw added a comment.

Looks reasonable. Here's some suggestions on prior integration tests that can be cargo culted.

If you are OK playing with a hex editor, making a test similar to llvm/test/tools/llvm-xray/X86/convert-fdr-to-yaml.txt could be a quick sanity check.

llvm/projects/compiler-rt/test/xray/TestCases/Linux/fdr-mode.cc uses a REQUIRES: built-in-llvm-tree to be able to use llvm-xray convert within a lit test after instrumenting a binary as well. You might be able to do something clever to have the program emit the memory address and use lit to capture it and see that it matches the ENTER_ARG value.



================
Comment at: lib/XRay/Trace.cpp:228
   // We can encounter a CustomEventMarker anywhere in the log, so we can handle
   // it regardless of the expectation. However, we do se the expectation to read
   // a set number of fixed bytes, as described in the metadata.
----------------
we do se -> we do use?


https://reviews.llvm.org/D32840