[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

[Haojie Wang via Phabricator via llvm-commits]

haojiewang added inline comments.


================
Comment at: include/llvm/Bitcode/BitcodeWriter.h:89
+    ///
+    /// Index is required non-null.
+    /// 
----------------
mehdi_amini wrote:
> haojiewang wrote:
> > mehdi_amini wrote:
> > > Use a const reference then?
> > But M is actually also required non-null. I just used the same args list with writeModule. So here using const references instead of pointer is better?
> I believe references carry the non_null information explicitly as part of the API.
Sure, I mean should I also change pointer M to reference or just change the Index and ModHash? And also for pointer M in writeModule?


https://reviews.llvm.org/D35334