[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

Haojie Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 18:04:12 PDT 2017


haojiewang marked 2 inline comments as done.
haojiewang added inline comments.


================
Comment at: include/llvm/Bitcode/BitcodeWriter.h:89
+    ///
+    /// Index is required non-null.
+    /// 
----------------
mehdi_amini wrote:
> Use a const reference then?
But M is actually also required non-null. I just used the same args list with writeModule. So here using const references instead of pointer is better?


https://reviews.llvm.org/D35334





More information about the llvm-commits mailing list