[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/Bitcode/BitcodeWriter.h:87
 
+    /// Write the specified module summary to the buffer specified at constrction time.
+    ///
----------------
s/constrction/construction/


================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:100
 
-/// Class to manage the bitcode writing for a module.
-class ModuleBitcodeWriter : public BitcodeWriterBase {
-  /// Pointer to the buffer allocated by caller for bitcode writing.
-  const SmallVectorImpl<char> &Buffer;
-
+/// Abstrac class to manage the module bitcode writing, currently subclassed for
+/// ModuleBitcodeWriter and SummaryBitcodeWriter
----------------
s/Abstrac/Abstract/

But in fact I don't think it class is abstract, is it? 


================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:4007
+
+/// Class to manage the bitcode writing for a module summary.
+class SummaryBitcodeWriter : public ModuleBitcodeWriterBase {
----------------
Is a "module summary" described anywhere?


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:426
   if (ThinLinkOS) {
     StripDebugInfo(M);
+    WriteSummaryToFile(&M, *ThinLinkOS, Index, &ModHash);
----------------
This should be obsolete right now?


https://reviews.llvm.org/D35334