[PATCH] D35228: [TableGen] Add support for instruction clusters

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 14:16:16 PDT 2017


fhahn added a comment.

Thanks @evandro , I think the example is really helpful to judge the impact of the set of changes.

I am not sure I see the clear advantages of the new approach over the macro fusion DAG mutation though. It seems to me that the new approach spreads out the implementation and definitions out over multiple files, whereas the DAG mutation is basically 2 files (the generic pass and the target specific implementation of shouldScheduleAdjecent) and it's relatively easy to see exactly what's going on, even though overall it probably requires slightly more code than the new approach.


Repository:
  rL LLVM

https://reviews.llvm.org/D35228





More information about the llvm-commits mailing list