[PATCH] D35325: [CMake] linker detection now handles Gnu LD, Solaris LD and LLD

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In https://reviews.llvm.org/D35325#807079, @ruiu wrote:

> I'm not sure if you need this. At least for https://bugs.llvm.org/show_bug.cgi?id=33698, it seems you can use --color-diagnostics (instead of -color-diagnostics).


33698 is not the only reason to know "is-Solaris-ld" answer.

There are more places where linker flags are being handled and where SunOS assumed == Solaris-ld, which is wrong:

  cmake/modules/AddLLVM.cmake:
        COMMENT "Creating export file for ${target_name}")
        if (${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
          set_property(TARGET ${target_name} APPEND_STRING PROPERTY
                      LINK_FLAGS "  -Wl,-M,${CMAKE_CURRENT_BINARY_DIR}/${native_export_file}")


https://reviews.llvm.org/D35325