[PATCH] D34977: [ELF] - Allow moving location counter backward in some cases.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 06:51:07 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1652-1668
+// Using linker script is it possible to assign any virtual addresses
+// to sections. We currently support only the case when all sections
+// in a PT_LOAD segment have assending VA order.
+static void checkSectionsOrder(OutputSection *FirstInPtLoad) {
+  std::vector<OutputSection *> V = getSectionsInLoad(FirstInPtLoad);
+  OutputSection *Prev = nullptr;
+  for (OutputSection *Sec : V) {
----------------
Can you remove this? It seems this is not directly related to the change you want to make.


https://reviews.llvm.org/D34977





More information about the llvm-commits mailing list