[llvm] r307789 - Make shell redirection construct portable

Kamil Rytarowski via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 06:24:46 PDT 2017


Author: kamil
Date: Wed Jul 12 06:24:46 2017
New Revision: 307789

URL: http://llvm.org/viewvc/llvm-project?rev=307789&view=rev
Log:
Make shell redirection construct portable

Summary:
NetBSD shell sh(1) does not support ">& /dev/null" construct.
This is bashism. The portable and POSIX solution is to use:
"> /dev/null 2>&1".

This change fixes 22 Unexpected Failures on NetBSD/amd64
for the "check-llvm" target.

Sponsored by <The NetBSD Foundation>

Reviewers: joerg, dim, rnk

Reviewed By: joerg, rnk

Subscribers: rnk, davide, llvm-commits

Differential Revision: https://reviews.llvm.org/D35277

Modified:
    llvm/trunk/test/Analysis/BasicAA/unreachable-block.ll
    llvm/trunk/test/Assembler/2003-11-11-ImplicitRename.ll
    llvm/trunk/test/Assembler/2007-11-26-AttributeOverload.ll
    llvm/trunk/test/CodeGen/X86/GC/badreadproto.ll
    llvm/trunk/test/CodeGen/X86/GC/badrootproto.ll
    llvm/trunk/test/CodeGen/X86/GC/badwriteproto.ll
    llvm/trunk/test/CodeGen/X86/GC/fat.ll
    llvm/trunk/test/CodeGen/X86/GC/outside.ll
    llvm/trunk/test/Other/2002-01-31-CallGraph.ll
    llvm/trunk/test/TableGen/UnterminatedComment.td
    llvm/trunk/test/Verifier/2004-05-21-SwitchConstantMismatch.ll
    llvm/trunk/test/Verifier/2007-12-21-InvokeParamAttrs.ll
    llvm/trunk/test/Verifier/2008-01-11-VarargAttrs.ll
    llvm/trunk/test/Verifier/2009-05-29-InvokeResult1.ll
    llvm/trunk/test/Verifier/2009-05-29-InvokeResult2.ll
    llvm/trunk/test/Verifier/2009-05-29-InvokeResult3.ll
    llvm/trunk/test/Verifier/byval-1.ll
    llvm/trunk/test/Verifier/gcread-ptrptr.ll
    llvm/trunk/test/Verifier/gcroot-alloca.ll
    llvm/trunk/test/Verifier/gcroot-meta.ll
    llvm/trunk/test/Verifier/gcroot-ptrptr.ll
    llvm/trunk/test/Verifier/gcwrite-ptrptr.ll

Modified: llvm/trunk/test/Analysis/BasicAA/unreachable-block.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/unreachable-block.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Analysis/BasicAA/unreachable-block.ll (original)
+++ llvm/trunk/test/Analysis/BasicAA/unreachable-block.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: opt -basicaa -aa-eval -disable-output < %s >& /dev/null
+; RUN: opt -basicaa -aa-eval -disable-output < %s > /dev/null 2>&1
 
 ; BasicAA shouldn't infinitely recurse on the use-def cycles in
 ; unreachable code.

Modified: llvm/trunk/test/Assembler/2003-11-11-ImplicitRename.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/2003-11-11-ImplicitRename.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/2003-11-11-ImplicitRename.ll (original)
+++ llvm/trunk/test/Assembler/2003-11-11-ImplicitRename.ll Wed Jul 12 06:24:46 2017
@@ -1,8 +1,7 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 void %test() {
   %X = add int 0, 1
   %X = add int 1, 2
   ret void
 }
-

Modified: llvm/trunk/test/Assembler/2007-11-26-AttributeOverload.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/2007-11-26-AttributeOverload.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/2007-11-26-AttributeOverload.ll (original)
+++ llvm/trunk/test/Assembler/2007-11-26-AttributeOverload.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @atoi(i8*) nounwind readonly
 declare i32 @atoi(i8*)

Modified: llvm/trunk/test/CodeGen/X86/GC/badreadproto.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/GC/badreadproto.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/GC/badreadproto.ll (original)
+++ llvm/trunk/test/CodeGen/X86/GC/badreadproto.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 	%list = type { i32, %list* }
 

Modified: llvm/trunk/test/CodeGen/X86/GC/badrootproto.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/GC/badrootproto.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/GC/badrootproto.ll (original)
+++ llvm/trunk/test/CodeGen/X86/GC/badrootproto.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 	%list = type { i32, %list* }
 	%meta = type opaque

Modified: llvm/trunk/test/CodeGen/X86/GC/badwriteproto.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/GC/badwriteproto.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/GC/badwriteproto.ll (original)
+++ llvm/trunk/test/CodeGen/X86/GC/badwriteproto.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 	%list = type { i32, %list* }
 

Modified: llvm/trunk/test/CodeGen/X86/GC/fat.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/GC/fat.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/GC/fat.ll (original)
+++ llvm/trunk/test/CodeGen/X86/GC/fat.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @llvm.gcroot(i8**, i8*) nounwind
 

Modified: llvm/trunk/test/CodeGen/X86/GC/outside.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/GC/outside.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/GC/outside.ll (original)
+++ llvm/trunk/test/CodeGen/X86/GC/outside.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @llvm.gcroot(i8**, i8*)
 

Modified: llvm/trunk/test/Other/2002-01-31-CallGraph.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/2002-01-31-CallGraph.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Other/2002-01-31-CallGraph.ll (original)
+++ llvm/trunk/test/Other/2002-01-31-CallGraph.ll Wed Jul 12 06:24:46 2017
@@ -1,6 +1,6 @@
 ;  Call graph construction crash: Not handling indirect calls right
 ;
-; RUN: opt < %s -analyze -print-callgraph >& /dev/null
+; RUN: opt < %s -analyze -print-callgraph > /dev/null 2>&1
 ;
 
         %FunTy = type i32 (i32)

Modified: llvm/trunk/test/TableGen/UnterminatedComment.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/TableGen/UnterminatedComment.td?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/TableGen/UnterminatedComment.td (original)
+++ llvm/trunk/test/TableGen/UnterminatedComment.td Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-// RUN: not llvm-tblgen < %s >& /dev/null
+// RUN: not llvm-tblgen < %s > /dev/null 2>&1
 
 def x;
 

Modified: llvm/trunk/test/Verifier/2004-05-21-SwitchConstantMismatch.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2004-05-21-SwitchConstantMismatch.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2004-05-21-SwitchConstantMismatch.ll (original)
+++ llvm/trunk/test/Verifier/2004-05-21-SwitchConstantMismatch.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 
 

Modified: llvm/trunk/test/Verifier/2007-12-21-InvokeParamAttrs.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2007-12-21-InvokeParamAttrs.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2007-12-21-InvokeParamAttrs.ll (original)
+++ llvm/trunk/test/Verifier/2007-12-21-InvokeParamAttrs.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @foo(i8*)
 

Modified: llvm/trunk/test/Verifier/2008-01-11-VarargAttrs.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2008-01-11-VarargAttrs.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2008-01-11-VarargAttrs.ll (original)
+++ llvm/trunk/test/Verifier/2008-01-11-VarargAttrs.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 	%struct = type {  }
 

Modified: llvm/trunk/test/Verifier/2009-05-29-InvokeResult1.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2009-05-29-InvokeResult1.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2009-05-29-InvokeResult1.ll (original)
+++ llvm/trunk/test/Verifier/2009-05-29-InvokeResult1.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 

Modified: llvm/trunk/test/Verifier/2009-05-29-InvokeResult2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2009-05-29-InvokeResult2.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2009-05-29-InvokeResult2.ll (original)
+++ llvm/trunk/test/Verifier/2009-05-29-InvokeResult2.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 

Modified: llvm/trunk/test/Verifier/2009-05-29-InvokeResult3.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/2009-05-29-InvokeResult3.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/2009-05-29-InvokeResult3.ll (original)
+++ llvm/trunk/test/Verifier/2009-05-29-InvokeResult3.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 

Modified: llvm/trunk/test/Verifier/byval-1.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/byval-1.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/byval-1.ll (original)
+++ llvm/trunk/test/Verifier/byval-1.ll Wed Jul 12 06:24:46 2017
@@ -1,2 +1,2 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 declare void @h(i32 byval %num)

Modified: llvm/trunk/test/Verifier/gcread-ptrptr.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcread-ptrptr.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/gcread-ptrptr.ll (original)
+++ llvm/trunk/test/Verifier/gcread-ptrptr.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }

Modified: llvm/trunk/test/Verifier/gcroot-alloca.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-alloca.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-alloca.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-alloca.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }

Modified: llvm/trunk/test/Verifier/gcroot-meta.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-meta.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-meta.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-meta.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }

Modified: llvm/trunk/test/Verifier/gcroot-ptrptr.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-ptrptr.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-ptrptr.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-ptrptr.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }

Modified: llvm/trunk/test/Verifier/gcwrite-ptrptr.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcwrite-ptrptr.ll?rev=307789&r1=307788&r2=307789&view=diff
==============================================================================
--- llvm/trunk/test/Verifier/gcwrite-ptrptr.ll (original)
+++ llvm/trunk/test/Verifier/gcwrite-ptrptr.ll Wed Jul 12 06:24:46 2017
@@ -1,4 +1,4 @@
-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }




More information about the llvm-commits mailing list