[PATCH] D35279: [Dominators] Improve reachability verification

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 20:42:12 PDT 2017


>
>
> ================
> Comment at: include/llvm/Support/GenericDomTreeConstruction.h:305
> +
> +      if (!BB || NodeToInfo.count(BB) == 0) {
>          errs() << "DomTree node ";
> ----------------
> When is it possible to have !BB but it's not a virtual root?
> If it's really possible, please document this condition.
>
>
In particular, we know that unreachable blocks have no dom tree nodes, but
this appears to be the reverse:
A dom tree node that has no CFG block.

If that's a thing now, it deserves documentation :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170711/9722f05d/attachment.html>


More information about the llvm-commits mailing list