[PATCH] D34337: [PPC] Fix two bugs in frame lowering.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 18:24:30 PDT 2017


Note that this change broke 

test/CodeGen/PowerPC/tailcall1-64.ll

on macOs builders. Part of that can be blamed on the test being written in a bad way where it just uses `-mcpu=xxx` which gives you a combination of the Host OS + the xxx CPU => test behavior changes with the host system.

I fixed this by changing the test to use `-mtriple=ppc64--` to get the builders back to green. Please double check if that change makes sense, I don't know much about ppc.

- Matthias

> On Jul 11, 2017, at 9:42 AM, Tony Jiang via Phabricator via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL307672: [PPC] Fix two bugs in frame lowering. (authored by jtony).
> 
> Changed prior to commit:
>  https://reviews.llvm.org/D34337?vs=105796&id=106055#toc
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D34337
> 
> Files:
>  llvm/trunk/lib/Target/PowerPC/PPCFrameLowering.cpp
>  llvm/trunk/lib/Target/PowerPC/PPCSubtarget.h
>  llvm/trunk/test/CodeGen/PowerPC/ppc-redzone-alignment-bug.ll
>  llvm/trunk/test/CodeGen/PowerPC/svr4-redzone.ll
>  llvm/trunk/test/CodeGen/PowerPC/tailcall1-64.ll
> 
> <D34337.106055.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list